Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(🦾): bump python simplejson 3.17.3 -> 3.19.2 #27757

Merged
merged 2 commits into from
Apr 1, 2024
Merged

chore(🦾): bump python simplejson 3.17.3 -> 3.19.2 #27757

merged 2 commits into from
Apr 1, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the python "simplejson" library version from 3.17.3 to 3.19.2.

Generated by @supersetbot 🦾

@mistercrunch mistercrunch reopened this Mar 28, 2024
@github-actions github-actions bot force-pushed the supersetbot-bump-simplejson branch from 7f110ea to e984a7f Compare March 28, 2024 01:42
@github-actions github-actions bot force-pushed the supersetbot-bump-simplejson branch from e984a7f to 633b1b9 Compare March 28, 2024 07:13
@mistercrunch mistercrunch reopened this Mar 28, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.88%. Comparing base (e1e3b99) to head (998c686).
Report is 1309 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #27757      +/-   ##
==========================================
+ Coverage   67.47%   69.88%   +2.40%     
==========================================
  Files        1911     1912       +1     
  Lines       75024    75033       +9     
  Branches     8355     8355              
==========================================
+ Hits        50625    52439    +1814     
+ Misses      22349    20544    -1805     
  Partials     2050     2050
Flag Coverage Δ
hive 48.93% <0.00%> (?)
mysql 77.90% <100.00%> (-0.01%) ⬇️
postgres 78.01% <100.00%> (-0.01%) ⬇️
presto 53.64% <100.00%> (?)
python 83.14% <100.00%> (+4.98%) ⬆️
sqlite 77.45% <100.00%> (-0.01%) ⬇️
unit 56.75% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch
Copy link
Member

Dug into this one and they switched allow_nan defaults from True to False within that release range. More info here simplejson/simplejson#324

@mistercrunch
Copy link
Member

So I was thinking, why do we need simplejson in the first place? Is it faster than the standard lib one? Turns out it's quite a rabbit hole: https://stackoverflow.com/questions/712791/what-are-the-differences-between-json-and-simplejson-python-modules .

I'd vote for using the standard lib and simplifying out of simplejson, especially if it's essentially the same thing (?)

@mistercrunch mistercrunch merged commit a664e21 into master Apr 1, 2024
37 checks passed
@mistercrunch mistercrunch deleted the supersetbot-bump-simplejson branch April 1, 2024 16:43
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request Apr 4, 2024
@github-actions @actions-user
@mistercrunch @jzhao62
chore(🦾): bump python simplejson 3.17.3 -> 3.19.2 (apache#27757)
a20cd2f 
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Maxime Beauchemin <[email protected]>
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
@github-actions @actions-user
@mistercrunch @EandrewJones
chore(🦾): bump python simplejson 3.17.3 -> 3.19.2 (apache#27757)
de8a75f 
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Maxime Beauchemin <[email protected]>
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
@github-actions @actions-user
@mistercrunch @EnxDev
chore(🦾): bump python simplejson 3.17.3 -> 3.19.2 (apache#27757)
5580b09 
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Maxime Beauchemin <[email protected]>
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@github-actions @actions-user
@mistercrunch @qleroy
chore(🦾): bump python simplejson 3.17.3 -> 3.19.2 (apache#27757)
016deb5 
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Maxime Beauchemin <[email protected]>
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@github-actions @actions-user @mistercrunch
chore(🦾): bump python simplejson 3.17.3 -> 3.19.2 (apache#27757)
ba341f9 
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Maxime Beauchemin <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS supersetbot 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @actions-user